feat: Deprecate spec.LoadBalancerIP in favor of annotations#115
Merged
feat: Deprecate spec.LoadBalancerIP in favor of annotations#115
Conversation
…p support Replace deprecated spec.LoadBalancerIP with the ServiceAnnotationLoadBalancerAddress annotation as the primary way to request a specific IP. Add ServiceAnnotationLoadBalancerKeepIP annotation to control IP retention on service deletion (breaking change: spec.LoadBalancerIP no longer prevents IP release). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Live IP reassignment adds significant complexity for a feature most cloud providers don't offer. OpenStack (architecturally closest to CloudStack) explicitly declined to implement it. Replace the IP switch branch with a warning event telling users to delete and recreate the service instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ookup Store the CloudStack public IP UUID and network UUID as service annotations so that subsequent reconciliation loops can look up load balancer rules by exact ID instead of relying on keyword-based LIKE %keyword% matching. The new getLoadBalancer orchestrator tries ID-based lookup first and falls back to name-based search when annotations are absent or stale. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hrak
requested review from
FarnazBGH,
jpsfalcao,
kasperhendriks and
suhasagasthya
suhasagasthya
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudstack-load-balancer-addressannotation user-settable to request a specific IP (replacing the deprecatedspec.LoadBalancerIP), and add acloudstack-load-balancer-keep-ipannotation to retain IPs across service deletionload-balancer-id,load-balancer-network-id), enabling exact ID-based lookups instead of CloudStack's unreliable keywordLIKE %keyword%matching, with automatic fallback to name-based searchTest plan
go test ./cloudstack/...)getLoadBalancerAddressprecedence,getLoadBalancerByID,getLoadBalancerorchestrator (ID hit, stale fallback, no annotation, API error),keep-ipbehavior inshouldReleaseLoadBalancerIPgo build ./...succeedsgolangci-lint runpasses clean🤖 Generated with Claude Code